Design comparison
Solution retrospective
My first project using JavaScript. My first javascript code exceeded 80 lines and I realized that I could reduce the amount of lines. I did some research, asked ChatGPT and came up with this result.
It took me a while to finish the project, so my style.css might be a little messy because I kept forgetting the styles I put in.
Any feedback is welcome.
Community feedback
- @VCaramesPosted almost 2 years ago
Hey there! 👋 Here is some feedback to further improve your code:
The HTML for the ratings needs to be rewritten as it was done incorrectly ❌:
To ensure that the "rating buttons" are fully accessible 💯, they need to be built using a
form
⚠️.- Everything will be wrapped inside a
fieldset
which will have alegend
that is visually hidden using CSS. - Inside, there should be five
input radios
and eachinput
should have alabel
attached to it to make the “ratings” accessible. - The last thing you will want to include will be a
button
so users can submit their choice.
Here is how it looks like fully implemented: EXAMPLE
More Info: 📚
- Once the top is implemented , for your JS, the
eventListener
should be on theform
⚠️ as asubmit
. It should only be 15 lines at max.
More Info:📚
Click vs. Submit EventListeners
If you have any questions or need further clarification, you can always check out my submission and/or feel free to reach out to me.
Happy Coding! 👾
Marked as helpful0 - Everything will be wrapped inside a
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord