Design comparison
Solution retrospective
This project was great fun. This is the first time im using jquery and i found it not complicated at all. Any feedback is welcome
Community feedback
- @elaineleungPosted about 2 years ago
Hi Joel, well done! Everything's working as it should, and I like how you included some logic for handling what happens when the user clicks submit without clicking a score. Great job also in getting it to look really close to the design. I haven't used jQuery in a really long time, so I'm out of touch with it; I did notice that it took a while to load the component, and so that might be due to the use of jQuery. I see that you had placed the script right under the body tag, which is a very interesting choice. I'm not familiar enough with it, but I would think it should go before the closing body tag instead of right after the opening body tag. Anyway, that's my only comment on jQuery.
The only thing left now is to check out the accessibility and HTML issues in the report; you're missing a
main
tag, but that's fairly easy to fix. All you need to do is change<div class="card">
to<main class="card">
, or alternatively, you can just add a newmain
tag as acontainer
, which is what I would do in this situation.Hope some of this helps you out!
Marked as helpful1
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord