Interactive Rating Solution (Vue 2, TypeScript)

Community feedback

• 

  T

  ApplePieGiraffe•30,545

  @ApplePieGiraffePosted over 2 years ago

  Hello there, Daniel Leite! 👋

  Nice job on this challenge! 👏 Your solution looks good and works well! 🙌

  One or two small things I'd like to suggest are,

  • Setting the alt text for the star icon in this challenge to an empty string so that it will be ignored by assistive technologies (since it isn't very important to the content of the page and as a result doesn't need to be read by screen readers).
  • Perhaps using a radio input element for the rating buttons in this challenge (since they have essentially the same functionality and doing so will automatically take care of certain things for you such as having only option selected at a time). 😉

  Hope you find this helpful. 😊

  Keep coding (and happy coding, too)! 😁

  Marked as helpful

  2
• 

  Alin Balog•200

  @FabzusPosted over 2 years ago

  Hello @Danielvermel!

  The design looks amazing, nice job!

  I'd like to suggest a small change:

  Your rating is n-1 (where n is the number selected), so if I want to rate you 5, I end up rating you a 4. You could try the easy fix, hardcode a +1 for your rating review. Or you could change the buttons to radio buttons and assign them values from

  Anyways you nailed the design! and I hope this was useful to you! With great respect, Balog Alin

  Marked as helpful

  1