Design comparison
Solution retrospective
This is my first time I integrated something with javascript and I learned how to modify html elements and css properties using addEventListener. I have no idea if I used the best practices to change the content of the card. I added a small js thing so we can easily change the range of the rating. Big range affect the design though, there must be some improvement to do there. I tried to add a little transition effect after submitting but I couldn't find how to do it.
Community feedback
- @isprutfromuaPosted over 2 years ago
Hi there. You did a good job 👍
keep improving your programming skills
your solution looks great, however, if you want to improve it, you can follow these steps:
🟢 can't navigate using the keyboard. Please add more semantic markup for it. Simple radio-buttons would be enough.
🟢 don't use tag selectors. When you add CSS directly on tags, your markup can’t change. Your style is tightly coupled to your DOM, and any change increases the risk of breaking things.
🟢 don’t use inline styling. Always put your style code in separate stylesheets.
I hope my feedback will be helpful
Good luck and fun coding 🤝⌨️
Marked as helpful1@geoffreyhachPosted over 2 years ago@isprutfromua thanks a lot for your feedback, I’ll definitely think about this in my futur projects.
0@isprutfromuaPosted over 2 years ago@geoffjecrois Hi there
I am glad that my help was useful to you
Cheers, peace and happy coding!
0
Please log in to post a comment
Log in with GitHub
Join our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord