Design comparison
SolutionDesign
Solution retrospective
Hi. This is my first ever published project using a really basic Javascript that I've learned so far (mostly DOM). I mostly need your input on Javascript code. How is it? Is there any other more effective approaches that I can use? Your feedback always means so much to me.
Community feedback
- @besttlookkPosted over 2 years ago
HI, Here are my few suggestions and bugs
- Dont let user move to thank you section without rating. Disable the button in that case. You can even give feedback to the user like "Please give a rating"
- Submit button needs some padding in y direction. There is a special property if you want to set padding in y direction in one line without worry about the padding in x direcition
{ padding-block: 2rem; // same as padding: 2rem 0 }
- Above submit button there be some more gap.
- "You selected 5 out of 5" this line in not perfectly aligned inside the box.
here is my solution: https://rating-rem.herokuapp.com/
Good luck, #happyCoding
Marked as helpful0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord