Interactive Rating Component(HTML, CSS and Vanilla JavaScript)
Design comparison
Solution retrospective
Making the component interactive wasn't an easy task for me. All feedbacks are welcomed on how I can improve the JavaScript file.
Community feedback
- @VCaramesPosted about 2 years ago
Hey there! 👋 Here are some suggestions to help improve your code:
-
Change
width
tomax-width
in your component’s container to make it responsive. You will also want to delete theheight
as it is unnecessary. -
The icons in this component serve no other purpose than to be decorative; They add no value. There Alt Tag should be left blank and have an aria-hidden=“true” to hide them from assistive technology.
-
The proper way to build this challenge is to create a Form and inside of it, the “rating buttons” should be built using an Input Radio and it should have a Label Element attached to it.
If you have any questions or need further clarification, feel free to reach out to me.
Happy Coding! 🍂🦃
Marked as helpful1 -
- @AdrianoEscarabotePosted about 2 years ago
Hi Zaid Mohammed Zainudeen, how are you?
I really liked the result of your project, but I have some tips that I think you will enjoy:
As you know this page is just a component, so it doesn't even need an
h1
! because we don't know how important the other components of the site will be! but it's always good to prevent accessibility errors so I think it would be good for you to add anh1
in this component, besides being a good practice for when you are developing larger sites, don't worry forget abouth1
.To improve the structure of the html document, prefer to wrap all the content with the
main
tag, since this challenge is just a component, it needs amain
tag to know what the main content of the page is!The rest is great!
I hope it helps... 👍
Marked as helpful1@iamzaidmohammedPosted about 2 years ago@AdrianoEscarabote Thanks. I'll do that next time.
0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord