Interactive rating component

Community feedback

• 

  バレンタイン 😈•64,170

  @VCaramesPosted about 2 years ago

  Hey there! 👋 Here are some suggestions to help improve your code:

  • Unless your company requires you to use a library , I strongly suggest you stay away from using libraries until you fully grasp the fundamentals of HTML, CSS and JS. By using a library, you are robbing yourself from actually learning how to code.

  • Change width to max-width in your component’s container to make it responsive. You will also want to delete the height as it is unnecessary.

  • To not only improve your HTML code but to identify the main content of you page, you will want to wrap your entire component inside the main element.

  More Info:📚

  MDN Main Element

  • The “icons/images” in this component serve no other purpose then to be decorative; They add no value. There Alt Tag should be left blank and have an aria-hidden=“true” to hide them from assistive technology.

  More Info:📚

  https://www.w3.org/WAI/tutorials/images/

  • The proper way to build this challenge is to create a form and inside of it, the “rating buttons” should be built using an input radio (wrap all of them inside a fieldset), since this will prevent additional buttons from being active at the same time, and it should have a label element attached to it for accessibility.

  More Info:📚

  MDN <input type="radio">

  MDN <fieldset>: The Field Set element

  • Currently, users can submit without selecting a rating. To fix this, you can do one of the following:

  1. Make the “5” rating the default rating.
  2. Create an error message, telling users they need make a section.
  3. Disable the button until a selection is made.

  If you have any questions or need further clarification, feel free to reach out to me.

  Happy Coding! 🍂🦃

  1

  ---

  

  Md. Saadman Galib Rabbi•140

  @saadman-galibPosted about 2 years ago

  @vcarames Hi! many many thanks for your valuable suggestion. I have updated JavaScript code to can only submit after selecting. and also I have added aria-hidden="true" to all img tags. I am taking all your suggestions I will keep it on my mind for my next projects. Thanks for reviewing my code and help me via the suggestion. Will you pls again check the code that does the JavaScript code running well?

  0