Design comparison
Solution retrospective
This is my first time integrating JS into a web page to add styling dynamically! Do you think there are any cleaner ways I can structure the CSS? I felt like the rating class wasn't necessary, but it was the easiest way to select the rating elements in the JS.
Community feedback
- @DavidMorgadePosted over 2 years ago
Hello Jeremy, congrats on finishing the challenge, you did a great job!
Probably would add some
cursor: pointers
to your rating buttons and also add it to the submit button, so it's easy for the user to understand that those are clickable buttons!You could also add some tranistions to those rating buttons and the submit button just by adding
transition: all 0.5s ease;
, it will have a smoother effect and it will look your component even more modern!.For the JS is ok to at a class to select that specific item, you could also have selected all of your
li
items and then looping through them in your for loop, you could have selected the buttons using theclosest()
method. But adding an extra class is also acceptable!Hope my feedback helps you! great job!
0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord