Used flexbox and

Community feedback

• 

  バレンタイン 😈•64,170

  @VCaramesPosted almost 2 years ago

  Hey there! 👋 Here are some suggestions to help improve your code:

  • It is best practice ✅ to use, classes for styling purposes, while using ids solely for JavaScript.

  • Remove all the br elements you added, they are unnecessary ❌.

  • Your form is lacking 😢 a visually hidden legend for accessibility and a fieldset to improve semantics.

  More Info: 📚

  MDN: Legend Element

  MDN: Field Set Element

  • For your JS, the eventListener should be on the form ⚠️ as a submit.

  More Info:📚

  Click vs. Submit EventListeners

  If you have any questions or need further clarification, feel free to reach out to me.

  Happy Coding! 🎆🎊🪅

  Marked as helpful

  0

  ---

  

  Pierre Allard•135

  @RondellAllardPosted almost 2 years ago

  @vcarames How are you so fast!??! lol

  Thank you!

  1

  

  バレンタイン 😈•64,170

  @VCaramesPosted almost 2 years ago

  @RondellAllard

  Glad I could help!

  Leaving feedback? 😄 I’ve seen this challenge a hundred times so, I know what to look for in the code.

  0

  

  Pierre Allard•135

  @RondellAllardPosted almost 2 years ago

  @vcarames

  Thank you again.

  I added classes to style the elements that have ids. I assume this is so that JS can have priority over the design when needed?

  I added the legend and fieldset.

  I, through much mental frustration, targeted the submit event on the page instead of the button.

  0