Design comparison
Solution retrospective
Hi, I would like to receive feedback on the JS part of my code.
to create the <small> tag of the pop-up window after submitting a rating, I needed the number of the rating to make it dynamic. So, I created an object, separated each index, and called them later, which worked. However, I would like to know if there is any simpler way to take the innerHTML of the rating chosen by the user or if the way I did is already good. I appreciate the help!
PS: whenever I looped through the nodelist, it returned all the elements and not each of them like in the first forEach() of the code.
Community feedback
- @itushPosted over 1 year ago
Congratulations on completing the challenge! 🎉
Your solution looks nice to me :)
- I used a for loop for this challenge. You may go through this to get some ideas.
In my projects:
- I always start with mobile-first workflow.
- I use at least one main element for a page (entire content goes into the main, if I'm not using header & footer), and avoid divs as much as possible and use section and article element wherever I can.
<body> <main> All content </main> </body>
-
I Use relative units as much as possible and avoid absolute units whenever possible.
-
If you are someone who is just starting out with front-end development, I strongly suggest starting with the QR code component project. Also in the challenges page you may filter by (Newbie, HTML&CSS) sort by (easier first) to select projects that will help you solidify your foundation. To avoid any potential knowledge gap⚠️ please first solidify HTML, CSS, JS fundamentals and then move on to any framework or library.
-
I remember when I started out, I made countless mistakes and spent long hours searching for solutions. But hey, you don't need to go through the same struggles! 🙌 To help you shorten the learning curve, I recommend going through the following articles. They contain valuable insights that can make your journey smoother:
📚🔍 12 important CSS topics where I discuss about css position, z-index, box-model, flexbox, grid, media queries, mobile-first workflow, best practices etc. in a simple way.
📚🔍 11 important HTML topics where I discuss about my thought process and approach to convert a design/mock-up to HTML along with important topics like block and inline elements, HTML Semantic Elements.
I hope you find these resources helpful in your coding adventures! 🤞
I'm eagerly looking forward to seeing the amazing projects you'll create in the future! 🚀💻
Keep up the fantastic work and happy hacking! 💪✨
Marked as helpful0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord