Interactive Rating Component with Sass and Js

Community feedback

• 

  Tiago José•300

  @tiago-jv0Posted about 2 years ago

  Hello Anuar, hope you are doing well, i saw your solution and I have a few tips that will help you improve your code quality :

  • About your ratings section, i saw that you created the ratings section using divs and toggle the active state using javascript, in order to improve this section, you can use custom checkboxes this will improve your semantics as well as code quality, doing that you can get ride of the javascript part where you set the active state when the use clicks the div

  Great job, carry on and you will be a great developer!!

  Marked as helpful

  1

  ---

  

  Anuar Zamudio Cortes•40

  @ZaphDevPosted about 2 years ago

  @tiago-jv0 oooh! thank you so much, thats a great idea, i'll definitely take it into account in the next challenge :D

  0
• 

  David•8,000

  @DavidMorgadePosted about 2 years ago

  Hey Anuar, congrats on finishing the challenge! great work getting your project to work!

  As I always say here on frontendmentor, your first Javascript projects should always look ugly, they don't need to look like the perfect code for the first time, the time will come and you will get much better at it, the important part when starting at JS should be to get it working and thats it. Great work!

  If you want some help refactoring to a better code with a little of explanation just ask me! (since you said in your comment that you already saw other people solution!)

  Hope my feedback helps you, and man really, don't take care about how your first JS projects look, just keep going, learn more about it, go for more tutorial / courses / documentation and keep doing projects!

  Marked as helpful

  1

  ---

  

  Anuar Zamudio Cortes•40

  @ZaphDevPosted about 2 years ago

  @DavidMorgade Thank you so much for the encouragement! i might take on your offer soon! Thank you so much for the feedback :)

  1