Luka Glonti• 3,440
@lack21
Posted
Good work 👍, but I have some recommendations!
- Replace
height: 100vhtomin-height: 100vhin thebody, the difference is that, when you setheight: 100vhto something, that means it won't be bigger than that, it might cause some problems in the future, so better approach is to setmin-height: 100vh, like this in case content is overflowing container will adjust to it! - Replace
width: 415pxin the.cardwith thewidth: min(415px, 90%), like this when screen width is smaller than.card,.cardwill adjust to it, and also removewidth: 330pxwhen it goes on smaller screens!
Marked as helpful
0
develoba• 270
@develoba
Posted
@lack21 you're right, I'll change it! Thanks for the help, I still need to learn best practices for responsiveness.
0
