Submitted about 2 years ago
Interactive rating component with flexbox
@Theuz1nh0
Design comparison
SolutionDesign
Solution retrospective
how was my project? I had a little trouble doing it, but I think in the end, it worked.
Community feedback
- @MelvinAguilarPosted about 2 years ago
Hi @Theuz1nh0 👋, good job on completing this challenge! 🎉
Here are some suggestions you might consider:
- You should not name your class or ids with the camelCase convention. Use naming naming conventions to name it.
- The star icon is for decoration purposes only, so it can be hidden from screen-readers by adding
aria-hidden="true"
and leaving its alt attribute empty:
<img src="./images/icon-star.svg" alt aria-hidden="true">
Good job, and happy coding!
Marked as helpful3@Theuz1nh0Posted about 2 years ago@MelvinAguilar thank you very much, i updated my code with the tips you gave me
1 - @AdrianoEscarabotePosted about 2 years ago
Hi Mateus Moura Domingos, how are you?
I really liked the result of your project, but I have some tips that I think you will enjoy:
To remove the scrollbar, we can do this:
body { /* margin: 1.5em; */ padding: 1.5em; }
The rest is great!
I hope it helps... 👍
Marked as helpful1@Theuz1nh0Posted about 2 years ago@AdrianoEscarabote thank you, i will do that
1
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord