Interactive rating component using HTML, CSS and JavaScript.
Design comparison
Solution retrospective
Any feedback is highly appreciated.
Community feedback
- @catherineisonlinePosted almost 2 years ago
Looks great. I would also add transitions for the hover effect so it's changing colors more smoothly. Also, instead of using a section tag and giving it the role="main", you can just use the main tag itself and place the copyright in the footer or in the main. 🙌🏻
Marked as helpful2 - @VCaramesPosted almost 2 years ago
Hey there! 👋 Here are some suggestions to help improve your code:
- The “icons/illustrations” in this component serve no other purpose than to be decorative; They add no value. There
alt tag
should be left blank and have anaria-hidden=“true”
to hide them from assistive technology.
More Info:📚
https://www.w3.org/WAI/tutorials/images/
- The proper way to build the "rating buttons" in this challenge is to create a
form
and inside of it, there should be fiveinput radios
and eachinput
should have alabel
attached to it to make the buttons accessible. Finally wrap all theinputs
andlabels
inside afieldset
to prevent users from making more than one selection.
More Info:📚
MDN <fieldset>: The Field Set element
- The
attribution
should be wrapped anfooter
element.
If you have any questions or need further clarification, feel free to reach out to me.
Happy Coding!🎄🎁
Marked as helpful1 - The “icons/illustrations” in this component serve no other purpose than to be decorative; They add no value. There
- @hernannadottiPosted almost 2 years ago
Hi @DanielLucaci awesome work !!!, just a little detail, if user didn´t select any rate, submit button should be disabled, disabled have no hover state.
Marked as helpful1@DanielLucaciPosted almost 2 years ago@hernannadotti Indeed, I forgot to take this into account, thanks a lot for your feedback.
0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord