Design comparison
Solution retrospective
Any feedback would be appreciated!
Community feedback
- @lidiakrajewskaPosted over 2 years ago
Hi! You did a great job, it looks very similar and the code seems logical.
But I've got a suggestion about media queries. As a general rule it's good to have as little media queries as possible, because it makes the code easier to maintain. Ussually no more than 3 media queries is needed. Actually you can build this one without any! :) You can try out this code:
.wrap { width: min(87%, 400px); }
On small screens it will has the width of 87%, but once that 87% will get bigger than 400px it won't grow anymore. That way your component will look great even on big screens. (Now it stretches on 2K monitor).
Marked as helpful2@victorsonetPosted over 2 years ago@lidiakrajewska Hey! Thanks for the feedback, I have been thinking about this already so its really helpful!
1
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord