Design comparison
Solution retrospective
First time added data-rating to the HTML.
What challenges did you encounter, and how did you overcome them?Learning about data-rating and implementing it to JS.
What specific areas of your project would you like help with?more efficient ways to improve the javascript.
Community feedback
- P@Fable54321Posted 4 months ago
So first, I think you know there is a few thing that are off with the design, so I won't go in-depth for these.
I am not a fan of having a boilerPlate.scss file. This project is small so it is not too bad, but on a bigger project, it would become a nightmare for someone trying to understand your styles. Plus, bigger projects will definitely have spome shared tags having completely different designs.
If you want to avoid repetition using sass you should look into mixins instead.
You have asked how to make the javascript better. Personally, I rarely use vanilla javascript for web development anymore, but I don't see anything wrong with what you did.
I like the querySelectorAll to make an array out of all the rating__number classes.
Of course, if you are serious about front-end engineering, you should consider looking into react.js pretty quickly, as it's pretty much a requirement for any job out there.
Overall good job, keep up !
0
Please log in to post a comment
Log in with GitHub
Join our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord