Interactive Rating Component using Sass, and BEM

Community feedback

• 

  バレンタイン 😈•64,170

  @VCaramesPosted almost 2 years ago

  Hey there! 👋 Here is some feedback to further improve your code:

  • The figure and article elements are being used incorrectly ⚠️ and not needed for this challenge.

  • The “icons/illustrations” in this component are purely decorative. ⚠️ Their alt tag should be left blank to hide them from assistive technology.

  More Info:📚

  https://www.w3.org/WAI/tutorials/images/

  • The HTML for the ratings needs to be rewritten as it was done incorrectly ❌:

  To ensure that the "rating buttons" are fully accessible 💯, they need to be built using a form ⚠️.

  1. Everything will be wrapped inside a fieldset which will have a legend that is visually hidden using CSS.
  2. Inside, there should be five input radios and each input should have a label attached to it to make the “ratings” accessible.
  3. The last thing you will want to include will be a button so users can submit their choice.

  More Info: 📚

  MDN: Form Element

  MDN: <input type="radio">

  MDN: Field Set Element

  • Once the top is implemented , for your JS, the eventListener should be on the form ⚠️ as a submit.

  More Info:📚

  Click vs. Submit EventListeners

  If you have any questions or need further clarification, you can always check out my submission and/or feel free to reach out to me.

  Happy Coding! 🤖

  Marked as helpful

  0

  ---

  

  Alex Garcia 🦝 Garcialexco•440

  @garcialexcoPosted almost 2 years ago

  @vcarames Thank you very much! I appreciate the thorough response, it helps out immensely. I will tweak this challenge and resubmit. Again, your comment is very helpful and if I could give you another few "Mark as helpful" points, I totally would. 👍

  2

  

  バレンタイン 😈•64,170

  @VCaramesPosted almost 2 years ago

  @garcialexco

  I'm glad that I was able to help!

  Keep it up!

  Marked as helpful

  1