Interactive Rating Component using Sass, and BEM
Design comparison
Solution retrospective
Hello! This is my solution for this challenge. π
This is my first Javascript project ever and I had a ton of fun building it! Please be very honest about any improvements I can make, I'm learning!
Any ideas on how to improve in any way are greatly appreciated! Much thanks. ππ½π»
Community feedback
- @VCaramesPosted over 1 year ago
Hey there! π Here is some feedback to further improve your code:
- The
figure
andarticle
elements are being used incorrectly β οΈ and not needed for this challenge.
- The βicons/illustrationsβ in this component are purely decorative. β οΈ Their
alt tag
should be left blank to hide them from assistive technology.
More Info:π
https://www.w3.org/WAI/tutorials/images/
- The HTML for the ratings needs to be rewritten as it was done incorrectly β:
To ensure that the "rating buttons" are fully accessible π―, they need to be built using a
form
β οΈ.- Everything will be wrapped inside a
fieldset
which will have alegend
that is visually hidden using CSS. - Inside, there should be five
input radios
and eachinput
should have alabel
attached to it to make the βratingsβ accessible. - The last thing you will want to include will be a
button
so users can submit their choice.
More Info: π
- Once the top is implemented , for your JS, the
eventListener
should be on theform
β οΈ as asubmit
.
More Info:π
Click vs. Submit EventListeners
If you have any questions or need further clarification, you can always check out my submission and/or feel free to reach out to me.
Happy Coding! π€
Marked as helpful0@garcialexcoPosted over 1 year ago@vcarames Thank you very much! I appreciate the thorough response, it helps out immensely. I will tweak this challenge and resubmit. Again, your comment is very helpful and if I could give you another few "Mark as helpful" points, I totally would. π
2@VCaramesPosted over 1 year ago@garcialexco
I'm glad that I was able to help!
Keep it up!
Marked as helpful1 - The
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord