Design comparison
SolutionDesign
Solution retrospective
This challenge helped me a lot to reinforce some basic React tools.
Community feedback
- @mseidel819Posted over 1 year ago
Very nice! I think you could move the
isSubmitted
andselectedValue
logic intoApp.js
. That way, you can keep the two components more separated.return isSubmitted ? (<Ranking rankingHandler={rankingHandler} /> ) : (<ThankYou selectedValue={selectedValue} /> );
I think this will clean up your files a little bit. As I type this, I realize you will have to use some props in your components, and some handlers for the scoring. I'm happy to talk more about it if you have questions or you're interested.
Marked as helpful0@lorenacrinconPosted over 1 year agoThank you very much! I will definitely try that to keep the code more organized. @mseidel819
0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord