@DavidMorgade
Posted
Hello Angelo, congrats on finishing the challenge! pretty good job using react + react router
If you don't mind I'll try to give you some feedback:
-
Regarding your question, you can place your main perfectly wrapping all of your rating component, and also the thank you component since they are a different page and are the main content of their corresponding page.
-
For the SCSS, you should try using SCSS modules, each SCSS file will only affect the component that is attach to, it will make your code more readable and also you will never have classes with the same name. Having your code structured in various files will always be a better approach than having everything in just one file.
-
As a React developer, I would also recommend you to separate your work in components, having everything in one big file takes out the magic of react, make components of everything, buttons, containers, text... in this little project maybe is not that usefull, but for large project it will help you not repeating yourself, and also having your code much more clean and organized.
Hope my feedback helps you, if you have any questions, don't hesitate to ask!
Marked as helpful
@Sengsith
Posted
@DavidMorgade Thank you for the feedback and tips, they are very helpful! I'd definitely like to try all of these out next time!
