Interactive rating component using HTML/CSS/JS
Design comparison
Solution retrospective
It's been a while since I did the last challenge. I'm not sure if the approach to make the pop up is right. It has the usual constrast issues from the colors provide by the challenges. Any feedback would be appreciated.
Community feedback
- @Sdann26Posted over 2 years ago
Hi Rogerio!
I think you have made one of the best projects I have seen for this challenge. Your layout and functionality is 10 out of 10.
I would only recommend you to add transitions with the transition attribute as follows transition: all 200ms (The first value indicates that it is to all properties and the second that it takes 200ms).
An example in the .rating class:
.rating { transition: background 200ms, color 200ms; }
This affects the background value and color. By the way I would recommend you always use it for buttons and links as well as animations to some other element.
On the other hand in accessibility issues at least I could have used buttons or radio-buttons with a form for the development of the card since semantically they make more sense for the development of this interactive card but well in the end you get to the desired solution but it would be good that you take it into consideration in some other challenge.
And nothing more to add, personally I like the way you have finally done it.
I hope my messages are helpful! Good Coding!
0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord