Interactive rating component Using html,css,js

Community feedback

• 

  Hyron•5,870

  @hyrongennikePosted about 2 years ago

  Hi,

  Congrats on completing the challenge.

  Just a few suggestions they're are small things but they important.

  1. I can click the submit button without selecting a value which gives me undefined you can fix this by either disabling the button if no rating has been selected or by adding a default value of one. Below is link to my solution.

  my solution

  2. Add a hover on the submit button when the user hovers over the button

  3. Look at the report and fix the accessibility issues for future challenges and projects just use semantic HTML tags to better describes you content.

  Hope you find these helpful

  Marked as helpful

  0

  ---

  

  Amjed Sahra•80

  @AmdjedSaneroPosted about 2 years ago

  @hyrongennike thank you for your feedback i will update the code , and for the submit button i think it is a active not hover !

  1

  

  Hyron•5,870

  @hyrongennikePosted about 2 years ago

  @AmdjedSanero yes it has an active state when click but as it is a button it needs a hover even it's just goes dark or lightens. it's something small I know but might as well get into the habit of adding extra things outside the brief you'll learn more that way as well.

  1
• 

  Oluwatosin Abigail Daramola•630

  @Heph-zibahPosted about 2 years ago

  This is impressive!

  Accessibility is also one of the issues I encounter here. This made me read up on it. Here is one of the link that can help you get better insight on the best practices. HTML Best Practices

  Kudos, once again

  1

  ---

  

  Amjed Sahra•80

  @AmdjedSaneroPosted about 2 years ago

  @Heph-zibah Thank you !

  0