Interactive rating component using HTML/CSS/JS
Design comparison
Solution retrospective
Any feedback is appreciated 🙏 🙏
Community feedback
- @didyouseekyngPosted over 2 years ago
Hello Ahmed! Nice to meet you here. Great job completing this challenge. I bet it was an exciting one to complete. Let me just chip in one or two suggestions based on your accessibility issues:
-
If you run through my code, most times I've been able to solve issues regarding labels by using the
aria-label
which creates a descriptive text for screen readers. -
You should always have one
h1
tag on your page as this is the most important heading tag on your page and it helps too for SEO. Read more about the importance of the h1 tag
Marked as helpful1@ahmedAgawadPosted over 2 years ago@didyouseekyng
-
Thanks very much for your feedback , i didnot know about aria attributes but i searched for them and of course i will try to learn more about this topic
-
I know this but i thought as this a small project i didnot have to put h1 as if this project is a part of real life project (full website) it would be a small section of page and of course the page would have its own h1
again big thanks for your feedback, have a good day.
0 -
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord