Design comparison
Solution retrospective
Feedbacks are welcome. I still think there is I can improve. I am unfamiliar with best practices in CSS. Please let me know.
Community feedback
- @Sdann26Posted over 2 years ago
Hi Aritr!
To your solution I would recommend adding more padding
<div class="card" id="one">
in addition to width and border-radius.On the other hand to the SUBMIT button add the letter-spacing attribute to separate the letters.
On the other hand I recommend you to eliminate the accessibility errors that the frontendmentor report has generated. For example you have the problem that you have not put a main tag in the flow of the project so you could change the
<div class="container">
by<main class="container">
since here is all the main content of your page.Finally change the <h2> to an <h1> as you need to have at least one h1 per web page.
With that you would eliminate all the errors in the report when you generate a new one after updating.
I hope my comments are helpful C:
Marked as helpful1@aritr84Posted over 2 years ago@Sdann26
Thanks, It was very helpful. I will make changes and update that here.
1
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord