Design comparison
Solution retrospective
This is one of my first js projects
I've done most of the challenge just missing the right colors for the inactive buttons and some styling for the response.
any tips on ways to improve will be greatly appreciated.
Community feedback
- @grace-snowPosted over 2 years ago
Hi
Really important to use a form element and radio inputs in a fieldset on this. It can't be a load of buttons like that.
Other things that's causing problems on mobile with content being cut off is the height 100vh. Never limit height like that when there is written content inside - you need to use min-height
Hope thats helpful,along with the comments above
Marked as helpful1@L1m1tzPosted over 2 years ago@grace-snow Thank you for the feedback. I limit my body's height so that I can get the container to the center, is there a different way to the container in the center without leaving a huge gap at the bottom?
0 - @Iamweird2Posted over 2 years ago
Hi, nice work so far.
-
To be very sure of the colors, you can open the design file on your browser, then open developer option by (control shift i) and search around for a dropper. you can also search online how to find a color dropper for your web browser.
-
You can also center the details on the submit page to improve the aesthetics.
-
Endeavor not to use style elements by tag name or with id, using classes all through saves time debugging and prevent issues with specificity
-
Using static units such as pixels for font size is also not advisable since page sizes vary, specify for font size in relation to the browser window size using rem or em.
I hope this helps. Have a nice day.
Marked as helpful1 -
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord