Skip to content
Submitted about 2 years ago

Interactive Rating Component using HTML, CSS, and JavaScript

Markusβ€’240
@mhjarvis
Preview site (opens in new tab)View code (opens in new tab)
This is a solution for...Interactive rating component
  • HTML
  • CSS
  • JS
1newbie

Design comparison

SolutionDesign

Solution retrospective

All feedback is welcome - especially regarding best practices or if there is a better/cleaner way of doing something.

I'm also looking to clean up my naming conventions for classes and variables while also trying to use more semantic markup. This is something I'm struggling with and would love to get a good resource for that may have helped you.

Thanks for viewing my project.

Community feedback

  • Adrianoβ€’38,060
    @AdrianoEscarabotePosted about 2 years ago

    Hi Markus, how are you?

    I really liked the result of your project, but I have some tips that I think you will enjoy:

    • We have to make sure that all the content is contained in a reference region, designated with HTML5 reference elements or ARIA reference regions.

    Example:

    native HTML5 reference elements:

    <body>
    <header>This is the header</header>
    <nav>This is the nav</nav>
    <main>This is the main</main>
    <footer>This is the footer</footer>
</body>

    ARIA best practices call for using native HTML5 reference elements instead of ARIA functions whenever possible, but the markup in the following example works:

    <body>
     <div role="banner">This is the header</div>
     <div role="navigation">This is the nav</div>
     <div role="main">This is the main</div>
     <div role="contentinfo">This is the footer</div>
</body>

    It is a best practice to contain all content, except skip links, in distinct regions such as header, navigation, main, and footer.

    Link to read more about: click here

    The rest is great!

    I hope it helps... πŸ‘

    Marked as helpful
    1
  • バレンタむン πŸ˜ˆβ€’64,190
    @VCaramesPosted about 2 years ago

    Hey there! πŸ‘‹ Here are some suggestions to help improve your code:

    • To specify the main content of you site you will want to wrap your entire component inside the Main Element.

    • Remove the Picture Element. It is not necessary.

    • The β€œrating buttons” should be built using an Input Radio and it should have a Label Element attached to it.

    • Add a cursor: pointer to your rating buttons.

    If you have any questions or need further clarification, let me know.

    Happy Coding! πŸ‘»πŸŽƒ

    Marked as helpful
    0

Please log in to post a comment

Log in with GitHub

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord