Interactive rating component using HTML & CSS
Design comparison
Solution retrospective
Hello Everyone!!!!! I am a newbie to the front-end learning world and I am starting my journey with solving small challenges from frontendmentor. This is my 2nd challenge.
Kindly review it and let me know where I can improve it.
Thank you
Happy Coding!!!!!!
Community feedback
- @TechNechPosted over 2 years ago
Hey, nice work you have done there. I would like to suggest a few changes to your CSS:
- Remove all the margin properties from your
div
with classouterbox
, Then just add
min-height: 100vh; display: grid; place-items: center;
. This will place your component right in middle.
Also I haven't seen you read the full challenge description. You need to add JS etc and another 'Thank You' component also. It's also good practice to separate your CSS and HTML code.
Marked as helpful0@Priyanshii677Posted over 2 years ago@TechNech Hey I have updated my solution and added the ThankYou page with the help of JS. Have a look and do share the feedback!!
0@TechNechPosted over 2 years ago@Priyanshii677 Yes, that's very nice to see. Although I would point out that :
-
Your component is not centered in the body. Please check my earlier comment.
-
If I don't select and number and submit it still goes to the ThankYou component.
0 - Remove all the margin properties from your
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord