Design comparison
Solution retrospective
Next challenge completed! I struggled a bit with styling the radio buttons but in the end it came out quite nice I think :) I disabled button when no rate is selected as it felt right thing to do :)
Any feedback will be more than appreciated :)
Community feedback
- @elaineleungPosted over 2 years ago
Hi Adrian, well done here, and like you I also used a disabled state for my submit button, although I did it only after submitting my solution so that it could look close to the design screenshot. Also, good to know you used radio buttons because I did that too, and what's especially well done is you still have focus styles on the radio and submit buttons! Maybe you just kept the default browser styles, but still that's better than no focus styles, and having the style would be good for screen reader users and those who use the tab key. I don't have any suggestions here really, just wanted to say great job! 😊
1@AdrianX19Posted over 2 years agoHi Elaine! That's a nice trick with changing stuff after submitting the challenge! ;) and I totally agree keeping the focus styles is a good thing! Thanks a lot for your feedback, really appreciate it! :))
1 - @andersonBrunuPosted over 2 years ago
Hello, good solution, and a good idea to use radio button, I used divs and added the onclick method which made it a little difficult to select an option and make the other one that is already selected change the style to normal but it worked kk, I didn't block the button, I imagined it as if the rating was 0 without any option selected, but I really liked your code, especially the radio button that facilitates dms in js
1@AdrianX19Posted over 2 years ago@andersonBrunu Thank you for your feedback, it's nice to get to know different way people approached the same task! :)
0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord