Interactive rating component using flex-box. First JavaScript project!

Community feedback

• 

  T

  ApplePieGiraffe•30,545

  @ApplePieGiraffePosted over 2 years ago

  Hi there, Illyaas! 👋

  Nice work on this challenge! 👍 Your card component looks good and functions well! 👏

  One or two small things I suggest are,

  • Adding cursor: pointer to the buttons in this challenge to let users know that those elements are clickable when they hover over them with their cursor.
  • Adding a .gitignore file to your repository so that you can avoid uploading certain unnecessary files (such as the .DS_store file) to your GitHub repository. You can learn more about .gitignore files and how to use them here, if you'd like. 🙂

  Hope you find these tips helpful. 😊

  Keep coding (and happy coding, too)! 😁

  Marked as helpful

  1

  ---

  

  Illyaas•700

  @Illyaas4ShowPosted over 2 years ago

  @ApplePieGiraffe I thought it already had a git ignore file. I thought it was added automatically. Thx I’ll check it out for next project. Is there any advantage of the git ignore?

  1

  

  T

  ApplePieGiraffe•30,545

  @ApplePieGiraffePosted over 2 years ago

  @Illyaas4Show

  The .gitignore file simply tells Git to ignore certain files in your repository so that you don't commit them to your project history. This can be useful for ignoring files that aren't important to your project (such as .DS_store) or for ignoring very large folders that are unnecessary to save (such as a node_modules folder). 😉

  0

  

  Illyaas•700

  @Illyaas4ShowPosted over 2 years ago

  @ApplePieGiraffe Would that change the performance or speed of the transfer?

  0

  

  T

  ApplePieGiraffe•30,545

  @ApplePieGiraffePosted over 2 years ago

  @Illyaas4Show

  It might if it helps you avoid uploading large folders such as a node_modules folder in a large project! 😉

  0

  

  Illyaas•700

  @Illyaas4ShowPosted over 2 years ago

  @ApplePieGiraffe Oh ok I get it now. Speaking of node_modules, I was trying to use node.js to install scss but my mac is not allowing me to do it by claiming that I am not administrator even though I am. Pls can you help with this or do you know who can help because it is also stoping me from installing canvas sketch

  0

  

  T

  ApplePieGiraffe•30,545

  @ApplePieGiraffePosted over 2 years ago

  @Illyaas4Show

  Hmm... IDK, maybe try using sudo when you install the package using your terminal? Your computer might ask for your password, then, but sometimes it works after that. 😅

  0

  

  Illyaas•700

  @Illyaas4ShowPosted over 2 years ago

  @ApplePieGiraffe last time it asked me to put in my password, it didn't let me type it in. maybe that's a me problem lol

  0
• 

  Idris_DY•190

  @IdrisDYPosted over 2 years ago

  Very good attempt but I think you can work on reducing the width of the overall container. It is overflowing horizontally so you might want to check your margin and padding in your CSS.

  0

  ---

  

  Illyaas•700

  @Illyaas4ShowPosted over 2 years ago

  @IdrisDY oh really? It isn’t overflowing on mine 😕

  0