Skip to content
Submitted almost 2 years ago

Interactive rating component using DOM manipulation.

Nathalia Esthevlana•20
@esthevlana
Preview site (opens in new tab)View code (opens in new tab)
This is a solution for...Interactive rating component
  • HTML
  • CSS
  • JS
1newbie

Design comparison

SolutionDesign

Solution retrospective

Hello everyone!

This is my second Frontend Mentor challenge. This one was a little harder for me because I still have a long way to go in learning javascript, so even though it was a very simple project I felt like throwing my notebook out the window.

I would love to receive feedback and tips for improvement! ❤️

Community feedback

  • バレンタイン 😈•64,190
    @VCaramesPosted almost 2 years ago

    Hey there! 👋 Here is some feedback to further improve your code:

    • Your rating buttons and submit button need to be wrapped inside a form, have a visually hidden legend for accessibility and a fieldset to improve semantics.

    More Info: 📚

    MDN: Legend Element

    MDN: Field Set Element

    • Your "thank you" content needs to be announced to screen readers ⚠️ when it appears, so it needs to be wrapped in an additional div and have an aria-live="polite".
    • For your JS, the eventListener should be on the form ⚠️ as a submit.

    More Info:📚

    Click vs. Submit EventListeners

    If you have any questions or need further clarification, feel free to reach out to me.

    Happy Coding! 🎆🎊🪅

    Marked as helpful
    0
    Nathalia Esthevlana•20
    @esthevlanaPosted almost 2 years ago

    @vcarames thank you so much for the tips! I'll read all the material you sent me and try to improve the code!

    0

Please log in to post a comment

Log in with GitHub

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord