Interactive Rating Component using CSS, HTML and JavaScript

Community feedback

• 

  Abdul Khaliq 🚀•72,560

  @0xabdulkhaliqPosted over 1 year ago

  Hello there 👋. Congratulations on successfully completing the challenge! 🎉

  • I have other recommendations regarding your code that I believe will be of great interest to you.

  ---

  HTML 🏷️:

  • This solution may cause accessibility errors due to lack of semantic markup, which causes lacking of landmark for a webpage and allows accessibility issues to screen readers, due to accessibility errors our website may not reach its intended audience, face legal consequences, and have poor search engine rankings, highlighting the importance of ensuring accessibility and avoiding errors.

  ---

  • What is meant by landmark ?, They used to define major sections of your page instead of relying on generic elements like <div> or <span>. They are use to provide a more precise detail of the structure of our webpage to the browser or screen readers

  ---

  • For example:
  • The <main> element should include all content directly related to the page's main idea, so there should only be one per page
  • The <footer> typically contains information about the author of the section, copyright data or links to related documents.

  ---

  • So resolve the issue by replacing the <div class="container"> element with the proper semantic element <main> along with <div class="attribution"> into a <footer> element in your index.html file to improve accessibility and organization of your page

  ---

  .

  I hope you find this helpful 😄 Above all, the solution you submitted is great !

  Happy coding!

  Marked as helpful

  1

  ---

  

  André Felipe•50

  @dedezeraPosted over 1 year ago

  hey @0xAbdulKhalid, Thank you very much for the tip and for the feedback my friend, I really should have left the HTML in a semantic way, I will never forget that detail again, thank you very much!

  0
• 

  Leonardo Romero•150

  @LeonardoR3DPosted over 1 year ago

  Hi, first of all congratulations on completing this challenge :D.

  And about your problem about changing the color of the buttons when they are pressed I think the easiest way to do it is to create a new rule in your CSS file where you select your buttons with the focus pseudoclass and change the background color, something like this.

  .numbers button:focus { background-color: var(--orange); }

  Insted of this

  .numbers button:active { background-color: var(--orange); }

  I hope this is helpful.

  Marked as helpful

  0

  ---

  

  André Felipe•50

  @dedezeraPosted over 1 year ago

  Yooo @LeonardoR3D, Your help was very useful my friend, thanks for your attention and feedback, I really appreciate it! I tested it here and I really managed to solve the problem with the background of the buttons, it's really cool to have a community with people like you who help us!

  1