Design comparison
Solution retrospective
am open to any comments or feedback
Community feedback
- @VenusYPosted over 2 years ago
The solution looks great! It's very similar to the design mockups, so good job on that front.
However, I noticed that the rating feature of the webpage doesn't work properly when you first use it. Regardless of which number you choose, the first time you rate it, it will always be 1 out of 5. I think this is because you've placed the event listener for the ratings inside the event listener for the submit button. If you separate them, it should fix the issue if I'm not mistaken.
Secondly, even if you don't actually select a number, it will still be 1 out of 5. This happens regardless of whether it's the first time the user is rating or not. I suspect this has something to do with the fact that the '1 out of 5' is hardcoded in your HTML document.
On the bright side, when you choose to rate again, it works fine as long as you select a number. It's cool that you added a feature that wasn't initially included in the design mockups.
I know that was a lot of writing, but I hope it helped!
Marked as helpful0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord