Design comparison
SolutionDesign
Solution retrospective
Feedback welcome
Community feedback
- @ErayBarslanPosted over 2 years ago
Hey there, excellent work on this one! Design looks good, it's responsive and everything works as supposed to. Nothing much to add. Some suggestions regarding semantic markup:
- You can change
.rating-box
div to<main class="rating-box">...</main
- Images requires
alt
attribute. Also on images just for design purposes you can hide it from screen readers so they directly jump to meaningful content like:<img src="images/icon-star.svg" alt="star icon" aria-hidden:"true">
Following these will result in better SEO. A little side note regarding JS, purpose of the challenge is to get use DOM manipulation through script so it's totally fine to change style with functions. But in case you haven't noticed, you can achieve the same with
hover
&focus
css selectors. Regardless, yours is a great solution and happy coding :)Marked as helpful1 - You can change
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord