Interactive rating component

Community feedback

• 

  Jinet Onyango•160

  @JonyangoPosted over 2 years ago

  Hi Samantha,

  First of all, good job getting most of the aspects of the solution to work. You have done well. As Johnny has already said, using radio buttons would have been a better HTML choice, especially when trying to ensure once a user picks a single value and if they change to a different value, only the value they have currently chosen is highlighted.

  Secondly, using your current approach, instead of listening for individual li elements, you could have listened for the click event on their parent element, enabling you to write the click event only once. This is something called event delegation. You can read about it here.

  Marked as helpful

  2
• 

  johnny-estrada•70

  @johnny-estradaPosted over 2 years ago

  Hi Samantha,

  Welcome back to coding! I just completed the same project and also struggled with the radio buttons. I had to google a lot before I got them right and the JavaScript section.

  Here's my feedback: Instead of list items, inputs with a type of radio button would have been a better choice for the HTML. Inputs allow us to use this cool CSS trick that lets us style the checked checkbox easily, and use less code in our JS. Here' the link to my solution if you're curious about how I solved it using form inputs: https://github.com/johnnye562/interactive-rating-component.

  Keep up the good work! Hope this helps!

  Cheers, Johnny

  Marked as helpful

  1

  ---

  

  Samantha Lippiatt•10

  @SamL2021Posted over 2 years ago

  @johnnye562 thank you and thank you for your feedback, I will definitely look at inputs instead of using the ul. I wanted to check out your solution but couldn't see your repository, perhaps its private?

  0

  

  johnny-estrada•70

  @johnny-estradaPosted over 2 years ago

  @SamL2021 You're welcome! I just updated the settings, so you should be able to see it now. If not, please let me know.

  Cheer, Johnny

  0