Interactive rating component (TypeScript)
Design comparison
Solution retrospective
Hi there π, Iβm Danil and this is my solution for this challenge. π
β‘ Performance:
90%-100% on lighthouse report and PageSpeed Insights. π
π οΈ Built With:
- Semantic HTML5 markup βοΈ
- Flexbox βοΈ
- Media queries βοΈ
π¨βπ» Languages Used:
- HTML βοΈ
- CSS (Vanilla) π¨
- TypeScript (Vanilla) π
Any suggestions on how I can improve and reduce unnecessary code are welcome!
Thank you. π₯
Community feedback
- @0xabdulkhaliqPosted over 1 year ago
Hello there π. Congratulations on successfully completing the challenge! π
- I have other recommendations regarding your code that I believe will be of great interest to you.
HEADINGS β οΈ:
- This solution lacks usage of
<h1>
so it can cause severe accessibility errors due to lack of level-one headings<h1>
- Every site must want only one
h1
element identifying and describing the main content of the page.
- An
h1
heading provides an important navigation point for users of assistive technologies, allowing them to easily find the main content of the page.
- So we want to add a level-one heading to improve accessibility by reading aloud the heading by screen readers, you can achieve this by adding a
sr-only
class to hide it from visual users (it will be useful for visually impaired users)
- Example:
<h1 class="sr-only">Interactive rating component</h1>
- If you have any questions or need further clarification, you can always check out
my submission
for another challenge where i used this technique and feel free to reach out to me.
.
I hope you find this helpful π Above all, the solution you submitted is great !
Happy coding!
Marked as helpful1@Rock-n-Roll-CRCPosted over 1 year ago@0xAbdulKhalid
Hi! Thank you very much for taking the time to review my solution! π€
I'm gonna revise my solution as soon as possible! π₯
And once again, I really appreciate your feedback. It's helpful, and from people like you I learn more new useful stuff every day! :D
0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord