Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

Javascript was hard

@brendowe

Desktop design screenshot for the Interactive rating component coding challenge

This is a solution for...

  • HTML
  • CSS
  • JS
1newbie
View challenge

Design comparison


SolutionDesign

Solution retrospective


My javascript needs to improve a bit, but what was really difficult was the logic. I felt like an idiot not being able to think of how to find a solution. If anyone has tips on how I can improve my thinking for programming I would appreciate it.

Community feedback

@VCarames

Posted

Hey there! 👋 Here are some suggestions to help improve your code:

Tip: Do not be so hard on yourself. If you haven’t already, join the FEM Slack channel. There you can always ask question if you get stuck.

  • It is best practice to use, classes for styling purposes, while using ids solely for JavaScript.
  • To ensure that the "rating buttons" are fully accessible, they need to be built using a form and inside of it, there should be fiveinput radios and each input should have a label attached to it to make the buttons accessible. Finally wrap all the inputs and labels inside a fieldset to prevent users from making more than one selection.

More Info: 📚

MDN: <input type="radio">

MDN: Field Set Element

  • Currently, users can submit without selecting a rating. To fix this, you can do one of the following:
  1. Make the “5” rating the default rating.
  2. Create an error message, telling users they need make a section.
  3. Disable the button until a selection is made.
  • The web development process can be made easier and expedite the process by implementing a CSS Reset.

Here are some examples that you can freely use:

Josh Comeau Reset

Eric Meyer Reset

  • For improved accessibility 📈 for your content, it is best practice to use rem for your font-size and other property value. While em is best for media-queries. Using these units gives users the ability to scale elements up and down, relative to a set value.

If you have any questions or need further clarification, feel free to reach out to me.

Happy Coding!🎄🎁

1

@brendowe

Posted

@vcarames Applying the tips now. Thank you so much for the love and for the time spent to help me <3

1

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord