Design comparison
SolutionDesign
Community feedback
- @VCaramesPosted almost 2 years ago
Hey there! 👋 Here are some suggestions to help improve your code:
- NEVER ❌ do this as it creates accessibility issues for users and it is outdated.
html { font-size: 62.5%; }
- Your
CSS Reset
is being underutilized. 😢 To fully maximize 💯 it, you will want to add more to it.
Here are some examples that you can freely use:
- For improved accessibility 📈 for your content, it is best practice to use
rem
for yourfont-size
and other property values. Whileem
is best formedia-queries
. Using these units gives users the ability to scale elements up and down, relative to a set value.
- Your
form
is lacking ⚠️ a visually hiddenlegend
for accessibility and afieldset
to prevent users from selecting more than one rating.
More Info: 📚
If you have any questions or need further clarification, feel free to reach out to me.
Happy Coding! 🎆🎊🪅
Marked as helpful1@KevhecPosted almost 2 years ago@vcarames I found your reply very helpful, I will apply the corresponding changes. The only thing I don't understand is how to use the fieldset element to prevent multiple selections.
1@VCaramesPosted almost 2 years ago@Kevhec
You would just wrap the rating buttons inside it. That’s only job of the
fieldset
. The browser will recognize the element and prevent more than one selection being made.1
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord