Interactive Rating Component using vanilla JS

Community feedback

• 

  Adriano•38,060

  @AdrianoEscarabotePosted almost 2 years ago

  Hi Martin, how are you? I really liked the result of your project, but I have some tips that I think you will enjoy:

  To align some content in the center of the screen, always prefer to use display: flex; it will make the layout more responsive!

  Example:

  body {
      margin: 0;
      padding: 0;
      display: flex;
      align-items: center;
      flex-direction: column;
      justify-content: center;
      min-height: 100vh;
  }
  

  To improve the code structure wrap this div:

  <div class="attribution">

  with the semantic tag footer

  The rest is great!

  I hope it helps... 👍

  Marked as helpful

  0

  ---

  

  Martin•40

  @MCotonPosted almost 2 years ago

  @AdrianoEscarabote. Two great suggestions, I'll be adding the semantic markup as suggested from now on.

  You are the second to point me at Flex, I think I need to take your advice onboard and start using it properly throughout these challenges.

  Thanks!

  1
• 

  Tomek•240

  @qntekPosted almost 2 years ago

  Hi there. Well, You could add underneath that window hidden paragraph with css value visibility = 'hidden'; It's content could be a message to pick one of those buttons. So:

  if (!value) { paragraph.style.visibility = 'visible'; } else display thankyou window.

  Marked as helpful

  0

  ---

  

  Martin•40

  @MCotonPosted almost 2 years ago

  @qntek Hi Tomek, yeah I thought about that after I had submitted it, it's good to have the thought confirmed, thank you.

  0