Design comparison
Solution retrospective
Hi all,
I'm excited to share my very first React App and Frontend Mentor Solution! I would love any feedback - especially related to my use of useState and props as I found this to be particularly challenging. I would also like to improve my knowledge on React and CSS best practices, so any suggestions would be much appreciated. Thanks so much!
-Tyler
Community feedback
- @Nickil13Posted over 2 years ago
Hi Tyler!
Awesome work. As far as CSS goes, I would suggest having cursor:pointer on your rating circles and submit button so they look visibly clickable. I also noticed your star image is clipped off at the bottom. If you wrap the image in a div or span and add the circle class to that instead of your img it should solve that.
For React, I believe Container is typically a wrapper component not a component that stands on its own. I would suggest calling it InteractiveRating, or something similar to indicate the purpose of the component.
And for additional clarity, in
Container
you could change the propratingNum={setSelector}
tosetRatingNum={setSelector}
.Marked as helpful0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord