Interactive rating component

Community feedback

• 

  Adriano•38,390

  @AdrianoEscarabotePosted almost 2 years ago

  Hi Mohamed Lajnef, how are you? I really liked the result of your project, but I have some tips that I think you will enjoy:

  Document should have one main landmark, this problem is being caused by the fact that there is no main tag around the main content of the page! Since this challenge is based on only one component, there is no other component more important than it on this page, so to solve this, wrap all the content with the main tag,

  It's always good to pay attention to the correct use of semantic html elements, as they are extremely important for people who use screen readers, to know what the main content of the page is in the case of the main tag!

  To improve the accessibility of the project you could have put an h1. Every page must contain a level 1 header, for people who use screen readers, identity what the main title is and follow the sequence h1-h5

  <h1>How did we do?</h1>

  The rest is great!

  I hope it helps... 👍

  Marked as helpful

  1

  ---

  

  Mohamed Lajnef•60

  @momolajnef1Posted almost 2 years ago

  @AdrianoEscarabote Buddy! I am doing fine. I hope you do too. I love your projects. I looked at them and felt inspired to keep going. Thank you for the feedback. Indeed I appreciate it a lot. New Information that I didn't know about. I will be more careful with the next projects.

  1
• 

  バレンタイン 😈•64,170

  @VCaramesPosted almost 2 years ago

  Hey there! 👋 Here are some suggestions to help improve your code:

  • Do not forget to update your code with everything the report found to be incorrect.

  • The “icons/illustrations” in this component serve no other purpose than to be decorative; Their alt tag should be left blank and have an aria-hidden=“true” to hide them from assistive technology.

  More Info:📚

  https://www.w3.org/WAI/tutorials/images/

  • The "rating buttons" should not be built using the anchor element, since the anchor is for linking internal/external content.

  • The proper way to build the "rating buttons" in this challenge is to create a form and inside of it, there should be fiveinput radios and each input should have a label attached to it to make the buttons accessible. Finally wrap all the inputs and labels inside a fieldset to prevent users from making more than one selection.

  More Info:📚

  MDN <input type="radio">

  MDN <fieldset>: The Field Set element

  If you have any questions or need further clarification, feel free to reach out to me.

  Happy Coding!🎄🎁

  0