Submitted over 1 year ago

Interactive rating component

Adham El Samahy•250

@AdhamElSamahy909

Preview site View code

This is a solution for...Interactive rating component

HTML
CSS
JS

1newbie

Design comparison

SolutionDesign

Solution retrospective

All feedback is welcome!!

Community feedback

C H A R A N 🎯•2,670

@0xabdulPosted over 1 year ago

Hello there well successfully completed the Interactive rating component

A Few feedback for improve your code
In Html :
Heading ⚠️
the html page Must be contained level of headings like <h1> <h2> <h3> ect we use the header tag line by line or sequence way
We Do✓
Ex :

<body>
<h1> How did we do? </h1>
<p>
Please let us know how we did with 
your support request. All feedback 
is appreciated to help us improve 
our offering!
</p>
<h2> Thank you! </h2>
<p>
We appreciate you taking the
time to give a rating. If you 
ever need more support, don’t
hesitate to get in touch!
</p>
</body>

Don't Do !
Ex :

<body>
<h2> How did we do? </h2>
<p>
Please let us know how we did with 
your support request. All feedback 
is appreciated to help us improve 
our offering!
</p>
<h2> Thank you! </h2>
<p>
We appreciate you taking the
time to give a rating. If you 
ever need more support, don’t
hesitate to get in touch!
</p>
</body>

The Main landmark♦️
th html page should be contained one main landmark so fix them
to clear the Accessibility reports using semantic elements or non semantic elements
for easy way to clear the all Accessibility reports using non - semantic elements Ex : <div> , <span>
let's try
Ex :

<body>
<div class="container" role="main">
//Html code here 🏷️
</div>
</body>

OR
using semantic elements Ex : <aside> <section> <main> <nav> <header> < footer>
Ex :

<body>
<header>company logo header name...</header>
<main> the main content here</main>
<footer>@Copy right Here</footer>
</body>
</html>

I Hope you find the solution and it's useful for you
Happy CodingAdham El Samahy🤩

Marked as helpful

Abdul Khaliq 🚀•72,560
@0xabdulkhaliqPosted over 1 year ago
Hello there 👋. Congratulations on successfully completing the challenge! 🎉

I have other recommendations regarding your code that I believe will be of great interest to you.

HTML 🏷️:

This solution generates accessibility error reports, "All page content should be contained by landmarks" is due to non-semantic markup, which lack landmark for a webpage

So fix it by replacing the element <div class="attribution"> the with semantic element <footer> in your index.html file to improve accessibility and organization of your page.

What is meant by landmark ?, They used to define major sections of your page instead of relying on generic elements like <div> or <span>

They convey the structure of your page. For example, The <footer> typically contains information about the author of the section, copyright data or links to related documents.

HEADINGS ⚠️:

And, this solution has also generated accessibility error report due to lack of level-one heading <h1>

Every site must want at least one h1 element identifying and describing the main content of the page.

An h1 heading provides an important navigation point for users of assistive technologies, allowing them to easily find the main content of the page.

So we want to add a level-one heading to improve accessibility by reading aloud the heading by screen readers, you can achieve this by adding a sr-only class to hide it from visual users (it will be useful for visually impaired users)

.

I hope you find this helpful 😄 Above all, the solution you submitted is great !

Happy coding!
Marked as helpful
0
Manish Patel•730
@savvystriderPosted over 1 year ago
Love the new color scheme and animation! Only thing I would suggest is lowering the opacity on the buttons before they're clicked on. It's hard to tell the states apart.
Marked as helpful
0

Please log in to post a comment

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord