Design comparison
SolutionDesign
Solution retrospective
Feedbacks are very much welcome.
Community feedback
- @Illyaas4ShowPosted over 2 years ago
This is a very nice solution. Well done! A few accessibility issues though...
Document should have one main landmark
- You need have have one, and only one<main>
tag per page. It helps screen readers navigate through the page.All page content should be contained by landmarks
- You page should have one<footer>
tag too for the reason listed above. You can add wrap the attribution in a<footer>
tag.
I hope this helps. Happy coding :)
Marked as helpful0@IkwemogenaPosted over 2 years ago@Illyaas4Show Thank you for your comments. I will improve on my next challenge.
0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord