Design comparison
SolutionDesign
Solution retrospective
Hi ! I've just started to learn js so i was wondering if there is other way to do this
Community feedback
- @romila2003Posted about 2 years ago
Hi Steeve,
Congratulations 🎉 for completing this challenge, it was a great attempt. The card looks great and is functional however there are some issues regarding your HTML and CSS.
- It is best practice to wrap your code within the
main
tag which would ensure that your content is wrapped within the correct landmarks e.g.<main class="container"></main>
- It is important to give all of your buttons, the
type
attribute such asbutton
orsubmit
depending on the type of button it is e.g.
<button class="btn" type="button"></button> <button class="submit" type="submit"></button>
Overall, great attempt and wish you the best for your future projects so keep coding 👍.
0 - It is best practice to wrap your code within the
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord