Design comparison
Solution retrospective
I had trouble with adding a click event to every rating number button. I watched a youtube video though and I was able to do it using the foreach() method. But is there another way or a more effective way to do this?
Community feedback
- @VCaramesPosted almost 2 years ago
Hey there! 👋 Here are some suggestions to help improve your code:
- Along with the blank
alt tag
, you also want to include thearia-hidden=“true”
to your “ images/illustrations” to fully remove them from assistive technology.
More Info:📚
https://www.w3.org/WAI/tutorials/images/
- The proper way to build the "rating buttons" in this challenge is to create a
form
and inside of it, there should be fiveinput radios
and eachinput
should have alabel
attached to it to make the buttons accessible. Finally wrap all theinputs
andlabels
inside afieldset
to prevent users from making more than one selection.
More Info:📚
MDN <fieldset>: The Field Set element
If you have any questions or need further clarification, feel free to reach out to me.
Happy Coding!🎄🎁
Marked as helpful1 - Along with the blank
- @AdrianoEscarabotePosted almost 2 years ago
Hi Mishael, how are you? I really liked the result of your project, but I have some tips that I think you will enjoy:
To make the submit button work only when the user selects a number, we can do this:
ratings.forEach((rate) => { rate.addEventListener("click", () => { rated.textContent = rate.textContent; submitBtn.addEventListener("click", () => { container.classList.add("thanks"); thanks.classList.remove("thanks"); }); }); });
The rest is great!
I hope it helps... 👍
0@mishael-codesPosted almost 2 years ago@AdrianoEscarabote Thanks for the feedback
Though I tried refactoring my code but it gave the same output. Do you have any other suggestions?
1
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord