Skip to content
Submitted about 2 years ago

Interactive rating component

Elis0u•130
@Elis0u
Preview site (opens in new tab)View code (opens in new tab)
This is a solution for...Interactive rating component
  • HTML
  • CSS
  • JS
1newbie

Design comparison

SolutionDesign

Solution retrospective

No mobile version :)

Community feedback

  • バレンタイン 😈•64,170
    @VCaramesPosted about 2 years ago

    Hey there! 👋 Here are some suggestions to help improve your code:

    • The icons serve no other purpose than to be decorative; They add no value. There Alt Tag should left blank and have an aria-hidden=“true” to hides it from assistive technology.

    • The proper way to build this challenge is to create a Form and inside of it, the “rating buttons” should be built using an Input Radio and it should have a Label Element attached to it.

    If you have any questions or need further clarification, let me know.

    Happy Coding! 👻🎃

    Marked as helpful
    0
    Elis0u•130
    @Elis0uPosted about 2 years ago

    @vcarames Thanks you for your helping !

    0
  • Adriano•38,390
    @AdrianoEscarabotePosted about 2 years ago

    Hi Elis0u, how are you?

    I really liked the result of your project, but I have some tips that I think you will enjoy:

    • We have to make sure that all the content is contained in a reference region, designated with HTML5 reference elements or ARIA reference regions.

    Example:

    native HTML5 reference elements:

    <body>
    <header>This is the header</header>
    <nav>This is the nav</nav>
    <main>This is the main</main>
    <footer>This is the footer</footer>
</body>

    ARIA best practices call for using native HTML5 reference elements instead of ARIA functions whenever possible, but the markup in the following example works:

    <body>
     <div role="banner">This is the header</div>
     <div role="navigation">This is the nav</div>
     <div role="main">This is the main</div>
     <div role="contentinfo">This is the footer</div>
</body>

    It is a best practice to contain all content, except skip links, in distinct regions such as header, navigation, main, and footer.

    Link to read more about: click here

    The rest is great!**

    I hope it helps... 👍

    Marked as helpful
    0
    Elis0u•130
    @Elis0uPosted about 2 years ago

    @AdrianoEscarabote Hi ! I'm very well, and you ?

    Thanks for your helping, I admit it's something I don't pay attention to.

    Thank you !

    1

Please log in to post a comment

Log in with GitHub

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord