Interactive Rating Component (my 3rd JS project)

Community feedback

• 

  Shashree Samuel•9,260

  @shashreesamuelPosted over 2 years ago

  Hey good job completing this challenge

  Keep up the good work

  Your solution looks great however I think that that the card title needs a bit of margin from the top using margin-top.

  In terms of your accessibility issues simply wrap all your content between main tags

  I hope this helps

  Cheers

  Happy coding 👍

  Marked as helpful

  0

  ---

  

  Nguyen Nguyen•340

  @jesuisbienbienPosted over 2 years ago

  @TheCoderGuru The margin-top is definitely needed. How could I miss that? :D Thank you! Happy coding.

  0
• 

  Prabhash Ranjan•2,540

  @besttlookkPosted over 2 years ago

  Hi, Nicely done. Only thing i can point out is :

  • On Active state of button. chage the color of to white. As of now it is not quite visible

  Also You can't reuse the ID. Id should always ne unique.

  <button id=`number` class=`number` type=`submit` value=`3`>3</buttton>
  <button id=`number` class=`number` type=`submit` value=`4`>4</but
  

  Remove the id.or give uninque id to each .

  Good luck, Happy Coding

  0

  ---

  

  Nguyen Nguyen•340

  @jesuisbienbienPosted over 2 years ago

  @besttlookk thank you. I'll update my code asap. :D

  1