Design comparison
SolutionDesign
Community feedback
- @VCaramesPosted almost 2 years ago
Hey there! 👋 Here are some suggestions to help improve your code:
- The proper way to build the "rating buttons" in this challenge is to create a
form
and inside of it, there should be fiveinput radios
and eachinput
should have alabel
attached to it to make the buttons accessible. Finally wrap all theinputs
andlabels
inside afieldset
to prevent users from making more than one selection.
More Info:📚
MDN <fieldset>: The Field Set element
If you have any questions or need further clarification, feel free to reach out to me.
Happy Coding!🎄🎁
0 - The proper way to build the "rating buttons" in this challenge is to create a
- @AdrianoEscarabotePosted about 2 years ago
Hi Victor Ekeocha-ibe, how are you? I really liked the result of your project, but I have some tips that I think you will enjoy:
To make the submit button work only when the user selects a number, we can do this:
rateButtons.forEach((rateButton, index) => { rateButton.addEventListener('click', () => { removeActive(); rateButton.classList.add("active"); rate = index + 1 ratingText.innerHTML = ` You selected ${rate} out of 5` submitButton.addEventListener('click', () => { contentContainer.classList.add("invisible") thankYouSection.classList.remove("invisible") if (rate === 0) { ratingText.innerHTML = ` You selected ${0} out of 5` } }) }) });
The rest is great!
I hope it helps... 👍
0@bluey-mainPosted about 2 years ago@AdrianoEscarabote thank you for your comment i will change that. Thank You 😊
1
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord