Design comparison
Solution retrospective
This is my first challenge using JavaScript, please if you have any advice or feedback it will be appreciated. Thanks for your time.
Community feedback
- @romila2003Posted about 2 years ago
Hi Yefri,
Congratulations 🎉 for completing this challenge, it was a great attempt however there are some issues regarding your HTML and CSS.
Instead of giving the container a
margin
of19.6rem auto 5rem;
, you could give use the flexbox property, to center the container, in the middle of the screen. Also, for your body, you could give the side a padding of around 20px, to prevent the card from touching the side of the screen.body { display: flex; justify-content: center; align-items: center; min-height: 100vh; padding: 0 20px; }
Overall, great attempt and wish you the best for your future projects.
Marked as helpful1@y25sanchezPosted about 2 years ago@romila2003 Thank you so much, I applied your recommendations. Have a nice day! thanks again.
1 - @Eniola-BakarePosted about 2 years ago
This looks good! Well done
1
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord