My solution For Interactive-rating-component

Community feedback

• 

  バレンタイン 😈•64,170

  @VCaramesPosted almost 2 years ago

  Hey there! 👋 Congrats on completing your first challenge!🎊🍻

  Here are some suggestions to help improve your code:

  • FEM Best practice ✅, before moving on to the next challenge, always check your FEM report, to see what is incorrect and update your code with it so that you would not make the same mistake over again. This should be the first thing that should be done ⚠️ right after submitting the challenge.

  • Every site/component should always have ✅ a main element to not only for semantic purposes but also help assistive technology find the main content of your content. For this challenge, it will serve as your components container ⚠️.

  More Info: 📚

  MDN Main Element

  • Avoid skipping heading levels ⚠️. Always start with the h1 (which can only be used once) and you will go down the hierarchy level depending on the heading’s importance.

  • To ensure that the "rating buttons" are fully accessible 💯, they need to be built using a form ⚠️.

  1. Everything will be wrapped inside a fieldset which will have a legend that is visually hidden using CSS.
  2. Inside, there should be five input radios and each input should have a label attached to it to make the “ratings” accessible.
  3. The last thing you will want to include will be a button so users can submit their choice.

  More Info: 📚

  MDN: <input type="radio">

  MDN: Field Set Element

  If you have any questions or need further clarification, feel free to reach out to me.

  Happy Coding! 🎆🎊🪅

  Marked as helpful

  1
• 

  Ahmed Mahrous•980

  @AhmedMahroussPosted almost 2 years ago

  Hey there! 👋 Congrats on completing your first challenge!🎊🍻

  Here are some suggestions to help improve your code:

  FEM Best practice ✅, before moving on to the next challenge, always check your FEM report, to see what is incorrect and update your code with it so that you would not make the same mistake over again. This should be the first thing that should be done ⚠️ right after submitting the challenge. Every site/component should always have ✅ a main element to not only for semantic purposes but also help assistive technology find the main content of your content. For this challenge, it will serve as your components container ⚠️. More Info: 📚

  MDN Main Element

  Avoid skipping heading levels ⚠️. Always start with the h1 (which can only be used once) and you will go down the hierarchy level depending on the heading’s importance. To ensure that the "rating buttons" are fully accessible 💯, they need to be built using a form ⚠️. Everything will be wrapped inside a fieldset which will have a legend that is visually hidden using CSS. Inside, there should be five input radios and each input should have a label attached to it to make the “ratings” accessible. The last thing you will want to include will be a button so users can submit their choice. More Info: 📚

  MDN: <input type="radio">

  MDN: Field Set Element

  If you have any questions or need further clarification, feel free to reach out to me.

  Happy Coding! 🎆🎊🪅

  0