Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

Interactive rating component

@serFar

Desktop design screenshot for the Interactive rating component coding challenge

This is a solution for...

  • HTML
  • CSS
  • JS
1newbie
View challenge

Design comparison


SolutionDesign

Solution retrospective


What do you recommend to improve this code?

Community feedback

Adriano 37,930

@AdrianoEscarabote

Posted

Hello Sérgio Faria, how are you? I truly loved your project's outcome, however I have some advice that I hope you'll find useful:

To make the submit button work only when the user selects a number we can do this:

const selected = (e) => {
    number = e.target.getAttribute('data-value');
    console.log(number);
    e.target.classList.add('active');
    for (let i = 0; i < selection.length; i++) {
        if (selection[i].getAttribute("data-value") !== number) {
            selection[i].classList.remove("active");
        }
    }
    note.innerHTML = ` <div class="selection--text"> You selected ${number} out of 5</div> `;
    button.addEventListener('click', () => {
        contRate.style.display = 'none';
        contResult.style.display = 'block'; 
    });
}

The remainder is excellent.

I hope it's useful. 👍

0

@VCarames

Posted

Hey there! 👋 Here are some suggestions to help improve your code:

  • To not only improve your HTML code but to identify the main content of you page, you will want to wrap your entire component inside the main element.

More Info:📚

MDN Main Element

  • The “icons/illustrations” in this component serve no other purpose than to be decorative; They add no value. There alt tag should be left blank and have an aria-hidden=“true” to hide them from assistive technology.

More Info:📚

https://www.w3.org/WAI/tutorials/images/

  • The proper way to build the "rating buttons" in this challenge is to create a form and inside of it, there should be fiveinput radios and each input should have a label attached to it to make the buttons accessible. Finally wrap all the inputs and labels inside a fieldset to prevent users from making more than one selection.

More Info:📚

MDN <input type="radio">

MDN <fieldset>: The Field Set element

If you have any questions or need further clarification, feel free to reach out to me.

Happy Coding!🎄🎁

0

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord