Interactive rating component

Community feedback

• 

  Adriano•38,390

  @AdrianoEscarabotePosted almost 2 years ago

  Hello glgaviria64, how are you? I truly loved your project's outcome, however I have some advice that I hope you'll find useful:

  To avoid a big code, we can make some changes.

  first we can use the same class on all the buttons:

  <button class="btncard" id="1">1</button>

  To get them all in js we will use this:

  const buttonCard = document.querySelectorAll(".btncard")

  and then to add the events, we can use the forEach method since we have an array of elements, and in each element we will add a click event with the necessary functionality:

  buttonCard.forEach(element => {
    element.addEventListener("click", () => {
      calificacion = element.textContent;
    });
  });
  

  The remainder is excellent.

  I hope it's useful. 👍

  0
• 

  Lagxy•110

  @LagxyPosted almost 2 years ago

  theres an issue when the user didn't select any number and it display undefined out of 5, i suggest you put the default value to 0.

  0
• 

  バレンタイン 😈•64,170

  @VCaramesPosted almost 2 years ago

  Hey there! 👋 Here are some suggestions to help improve your code:

  • The figure element is not needed ❌ since there is no figcaption attached to it.

  • The “icons/illustrations” in this component are purely decorative. ⚠️ Their alt tag should be left blank and have an aria-hidden=“true” to hide them from assistive technology.

  More Info: 📚

  https://www.w3.org/WAI/tutorials/images/

  • To ensure that the "rating buttons" are fully accessible 💯, they need to be built using a form ⚠️ and inside of it, there should be fiveinput radios and each input should have a label attached to it to make the buttons accessible. Finally wrap all the inputs and labels inside a fieldset to prevent users from making more than one selection.

  More Info: 📚

  MDN: <input type="radio">

  MDN: Field Set Element

  • Currently, users can submit without selecting a rating ⚠️. To fix this, you can do one of the following:

  1. Make the “5” rating the default rating.
  2. Create an error message, telling users they need make a selection.
  3. Disable the button until a selection is made.

  • Your CSS Reset is being underutilized. 😢 To fully maximize 💯 it, you will want to add more to it.

  Here are some examples that you can freely use:

  Josh Comeau Reset

  Eric Meyer Reset

  If you have any questions or need further clarification, feel free to reach out to me.

  Happy Coding! 🎆🎊🪅

  0